window: Avoid rising the window of already shown popovers
authorCarlos Garnacho <carlosg@gnome.org>
Fri, 12 Jun 2015 13:03:41 +0000 (15:03 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Fri, 12 Jun 2015 19:00:45 +0000 (21:00 +0200)
This breaks stacking, as popovers are repositioned sort of frequently
(even more after show/hide animations).

https://bugzilla.gnome.org/show_bug.cgi?id=750741

gtk/gtkwindow.c

index eea2a15379a3d046f6314d6a7c7ad019524a7535..7f6f3e3a2e13b6e4ebaf7e5b6fab939e1d647558 100644 (file)
@@ -11905,15 +11905,10 @@ _gtk_window_set_popover_position (GtkWindow                   *window,
   data->rect = *rect;
   data->pos = pos;
 
-  if (gtk_widget_is_visible (popover))
+  if (gtk_widget_is_visible (popover) && !data->window)
     {
-      if (!data->window)
-        {
-          popover_realize (popover, data, window);
-          popover_map (popover, data);
-        }
-      else
-        gdk_window_raise (data->window);
+      popover_realize (popover, data, window);
+      popover_map (popover, data);
     }
 
   if (need_resize)